On Sat, Feb 08, 2014 at 05:18:38PM +0100, Frederic Weisbecker wrote: > In order to remotely restart the watchdog hrtimer, update_timers() > allocates a csd on the stack and pass it to __smp_call_function_single(). > > There is no partcular need, however, for a specific csd here. Lets > simplify that a little by calling smp_call_function_single() > which can already take care of the csd allocation by itself.
Sounds simple enough. Acked-by: Don Zickus <[email protected]> > > Cc: Andrew Morton <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Don Zickus <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Jan Kara <[email protected]> > Cc: Jens Axboe <[email protected]> > Cc: Michal Hocko <[email protected]> > Cc: Srivatsa S. Bhat <[email protected]> > Signed-off-by: Frederic Weisbecker <[email protected]> > --- > kernel/watchdog.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > index 4431610..01c6f97 100644 > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -505,7 +505,6 @@ static void restart_watchdog_hrtimer(void *info) > > static void update_timers(int cpu) > { > - struct call_single_data data = {.func = restart_watchdog_hrtimer}; > /* > * Make sure that perf event counter will adopt to a new > * sampling period. Updating the sampling period directly would > @@ -515,7 +514,7 @@ static void update_timers(int cpu) > * might be late already so we have to restart the timer as well. > */ > watchdog_nmi_disable(cpu); > - __smp_call_function_single(cpu, &data, 1); > + smp_call_function_single(cpu, restart_watchdog_hrtimer, NULL, 1); > watchdog_nmi_enable(cpu); > } > > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
