> > + spdif_priv->big_endian = of_property_read_bool(np, "big-endian"); > > + if (spdif_priv->big_endian) > > + fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; > > Why not just: > if (of_property_read_bool(np, "big-endian")) > fsl_spdif_regmap_config.val_format_endian = REGMAP_ENDIAN_BIG; >
I just think maybe other places of the driver maybe use this. Yes, it could be removed just for now. See the next version please. Thanks very much, -- Best Regards, Xiubo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/