On 02/11/2014 11:38 AM, Colin King wrote: > From: Colin Ian King <[email protected]> > > Static analysis from cppcheck issued the following warning: > > [drivers/mfd/omap-usb-tll.c:255]: (warning) Found calculation > inside sizeof(). > > The current size calculation is not obvious and is easy to > miscomprehend, so re-work the size of the allocation based > on the size of the struct pointer and quantity to allocate. > > Signed-off-by: Colin Ian King <[email protected]> > --- > drivers/mfd/omap-usb-tll.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > index 5ee50f7..532eacab 100644 > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -252,7 +252,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) > break; > } > > - tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk * [tll->nch]), > + tll->ch_clk = devm_kzalloc(dev, sizeof(struct clk *) * tll->nch, > GFP_KERNEL); > if (!tll->ch_clk) { > ret = -ENOMEM; >
Thanks for the patch Colin. Acked-by: Roger Quadros <[email protected]> -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
