Hello Kishon,

> -----Original Message-----
> From: Kishon Vijay Abraham I [mailto:[email protected]]
> Sent: Tuesday, February 11, 2014 5:36 PM
> To: Mohit KUMAR DCG; [email protected]
> Cc: Pratyush ANAND; Viresh Kumar; spear-devel; linux-arm-
> [email protected]; [email protected]
> Subject: Re: [PATCH V6 07/12] phy: st-miphy-40lp: Add SPEAr1310 and
> SPEAr1340 PCIe phy support
> 
> On Tuesday 11 February 2014 03:00 PM, Mohit Kumar wrote:
> > From: Pratyush Anand <[email protected]>
> >
> > SPEAr1310 and SPEAr1340 uses miphy40lp phy for PCIe. This driver adds
> > support for the same.
> 
> What's up with SATA support for SPEAr1310? Do you have plans of adding it
> soon?
> >

- yes we will be doing it after this series is finalized.

[...]
> > +
> > +   regmap_update_bits(priv->misc, SPEAR1310_PCIE_MIPHY_CFG_1,
> > +                   SPEAR1310_PCIE_SATA_MIPHY_CFG_PCIE_MASK,
> > +                   SPEAR1310_PCIE_SATA_MIPHY_CFG_PCIE);
> > +
> > +   switch (priv->id) {
> 
> 'id' should be made as optional dt property since it's not used for 1340 no?
> 
- ok
Thanks
Mohit
N�����r��y����b�X��ǧv�^�)޺{.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z��w���?�����&�)ߢf��^jǫy�m��@A�a���
0��h���i

Reply via email to