Hi Arnaldo, > Can you try the following patch? > > It should fix another problem, i.e. we were allocating, but annotation > would fail in the !TUI case, as it would return at > symbol__inc_addr_samples when use_browser != 1, now it will allocate > and mark the right bucket. > > I'll have this in perf/urgent and will do the optimization of not > allocating those buckets in the report case when not doing integrated > annotation, i.e. report --stdio doesn't provide a way to go to the > annotation --stdio, so no point on allocating the buckets. Just on > 'annotate --stdio' we should allocate it, etc.
This fixes the issue, thanks! Tested-by: Anton Blanchard <[email protected]> Anton -- > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index 469eb679fb9d..7cf522523c12 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -489,7 +489,7 @@ static int symbol__inc_addr_samples(struct symbol > *sym, struct map *map, { > struct annotation *notes; > > - if (sym == NULL || use_browser != 1 || !sort__has_sym) > + if (sym == NULL || !sort__has_sym) > return 0; > > notes = symbol__annotation(sym); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
