On Fri, Feb 14, 2014 at 10:19 AM, Lee Jones <lee.jo...@linaro.org> wrote: >> >> + mutex_init(&max665x->iolock); >> > >> > What is this needed for? >> >> It was done for consistency with the other mfd drivers (maxim), e.g. >> 8997 or 8998 as the closest resemblence in this family. Would you >> prefer me removing this mutex locker? > > If you're not using mutexes, why would you need to initialise it?
Yeah, I had the same thought about an hour ago that this sneaked in because I was not originally using regmap, but now with the regmap usage, it is just a left-over. So, it is not even for consistency anymore. I was wrong claiming that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/