This is a DT-only driver, so make it depend on OF and remove of_match_ptr in
the code.

Signed-off-by: Axel Lin <axel....@ingics.com>
---
 drivers/regulator/Kconfig              |  2 +-
 drivers/regulator/tps65218-regulator.c | 14 ++++++--------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index b05da880..b7c95e8 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -515,7 +515,7 @@ config REGULATOR_TPS65217
 
 config REGULATOR_TPS65218
        tristate "TI TPS65218 Power regulators"
-       depends on MFD_TPS65218
+       depends on MFD_TPS65218 && OF
        help
          This driver supports TPS65218 voltage regulator chips. TPS65218
          provides six step-down converters and one general-purpose LDO
diff --git a/drivers/regulator/tps65218-regulator.c 
b/drivers/regulator/tps65218-regulator.c
index 1fb1db5..cec72fa 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -243,14 +243,12 @@ static int tps65218_regulator_probe(struct 
platform_device *pdev)
        int id;
 
        match = of_match_device(tps65218_of_match, &pdev->dev);
-       if (match) {
-               template = match->data;
-               id = template->id;
-               init_data = of_get_regulator_init_data(&pdev->dev,
-                                                     pdev->dev.of_node);
-       } else {
+       if (!match)
                return -ENODEV;
-       }
+
+       template = match->data;
+       id = template->id;
+       init_data = of_get_regulator_init_data(&pdev->dev, pdev->dev.of_node);
 
        platform_set_drvdata(pdev, tps);
 
@@ -274,7 +272,7 @@ static struct platform_driver tps65218_regulator_driver = {
        .driver = {
                .name = "tps65218-pmic",
                .owner = THIS_MODULE,
-               .of_match_table = of_match_ptr(tps65218_of_match),
+               .of_match_table = tps65218_of_match,
        },
        .probe = tps65218_regulator_probe,
 };
-- 
1.8.1.2



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to