On Fri, 04 Feb 2005 10:06:29 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > Bartlomiej Zolnierkiewicz wrote: > > On Wed, 2 Feb 2005 12:15:59 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > >>>25_ide_taskfile_cmd.patch > >>> > >>> All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl() > >>> converted to use REQ_DRIVE_TASKFILE. > >> > >>Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > >> > >>Index: linux-ide-export/drivers/ide/ide-disk.c > >>=================================================================== > >>--- linux-ide-export.orig/drivers/ide/ide-disk.c 2005-02-02 > >>10:28:06.527986413 +0900 > >>+++ linux-ide-export/drivers/ide/ide-disk.c 2005-02-02 > >>10:28:07.204876587 +0900 > >>@@ -750,7 +750,7 @@ static int set_multcount(ide_drive_t *dr > >> if (drive->special.b.set_multmode) > >> return -EBUSY; > >> ide_init_drive_cmd (&rq); > >>- rq.flags = REQ_DRIVE_CMD; > >>+ rq.flags = REQ_DRIVE_TASKFILE; > > > > > > Please instead fix ide_init_drive_cmd() to set REQ_DRIVE_TASKFILE > > and add set REQ_DRIVE_CMD only in ide_cmd_ioctl(). > > > > This is done in patch #28. If you don't like the ordering of the > patches, I can change the orders but I don't think that improves > anything. This order is as good as the other order.
Actually no - if you change this then patch #28 becomes NOP. So please do it, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
