Wolfram Sang <[email protected]> wrote: > Although SMBus has no 10-bit addresses, we probably should also use %03x > there for consistency reasons?
Done. > Also, the I2C tracing has first 'f' then 'a', that should be consistent, > too. Flags first or address first? Do you have a preference (for both)? > 'flags' should be %04x again Done. > and I'd prefer %*ph (or %*phD) for the buffer. Again, I'm not so certain. > Can we have something like this for 'flags'? There's a __print_flags() which should work. One thing I'm concerned about there is how do we handle more flags being added - does that count as an ABI break if the printed format changes? SMBus flags are basically the same as I2C flags, right? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
