----- Original Message ----- > From: "Rashika Kheria" <[email protected]> > To: [email protected] > Cc: "Rashika Kheria" <[email protected]>, "Mathieu Desnoyers" > <[email protected]>, "Sasha Levin" > <[email protected]>, "Andrew Morton" <[email protected]>, "Paul > E. McKenney" > <[email protected]>, "Sahara" <[email protected]>, > [email protected] > Sent: Thursday, February 27, 2014 7:22:05 AM > Subject: [PATCH 37/46] kernel: Include appropriate header file in tracepoint.c > > Include appropriate header file include/trace/events/syscalls.h in > kernel/tracepoint.c because it has prototype definition of functions > defined in kernel/tracepoint.c. > > This eliminates the following warning in kernel/tracepoint.c: > kernel/tracepoint.c:738:6: warning: no previous prototype for > ‘syscall_regfunc’ [-Wmissing-prototypes] > kernel/tracepoint.c:755:6: warning: no previous prototype for > ‘syscall_unregfunc’ [-Wmissing-prototypes]
Tracepoints are the infrastructure on which trace events are build. tracepoint.c should not include a trace event header: this is an abstraction inversion. I propose we move the extern void syscall_regfunc(void); extern void syscall_unregfunc(void); declarations to include/linux/tracepoint.h instead. Thanks, Mathieu > > Signed-off-by: Rashika Kheria <[email protected]> > Reviewed-by: Josh Triplett <[email protected]> > --- > kernel/tracepoint.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c > index 0e26255..124d733 100644 > --- a/kernel/tracepoint.c > +++ b/kernel/tracepoint.c > @@ -26,6 +26,7 @@ > #include <linux/slab.h> > #include <linux/sched.h> > #include <linux/static_key.h> > +#include <trace/events/syscalls.h> > > extern struct tracepoint * const __start___tracepoints_ptrs[]; > extern struct tracepoint * const __stop___tracepoints_ptrs[]; > -- > 1.7.9.5 > > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
