[ Dropped Chen Gang, Tony Lu, Chris Metcalf and Robin Holt as their emails are bouncing for me ]
On Thu, 27 Feb 2014 08:43:36 -0800 Josh Triplett <j...@joshtriplett.org> wrote: > > > +void __weak panic_smp_self_stop(void); > > > > Is __weak required in a prototype? What about the override that is not > > weak. > > That's a good question. It's definitely not required, and should be > dropped. What I don't know is if it's broken to include it: does it > make the non-weak definition weak? I don't think so, but it is inconsistent. Best to not include it in the prototype. This is a clean up patch after all. Lets not clean up one thing and make something else messy in the process. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/