----- Original Message ----- > From: "Steven Rostedt" <[email protected]> > To: "Mathieu Desnoyers" <[email protected]> > Cc: [email protected], "Ingo Molnar" <[email protected]>, "Andrew > Morton" <[email protected]>, > "Peter Zijlstra" <[email protected]>, "Frederic Weisbecker" > <[email protected]>, [email protected], > "Mathieu Desnoyers" <[email protected]> > Sent: Thursday, February 27, 2014 12:09:25 PM > Subject: Re: [RFA][PATCH 5/5] tracepoint: Warn and notify if tracepoints are > not loaded due to module taint > > On Thu, 27 Feb 2014 16:33:50 +0000 (UTC) > Mathieu Desnoyers <[email protected]> wrote: > > > > I'd recommend the following message instead: > > > > pr_err("Module '%s' is tainted, ignoring its tracepoints\n", > > > > Better?
Yep, thanks! Acked-by: Mathieu Desnoyers <[email protected]> > > -- Steve > > From 08ea384dc937d75a2a1444a06c3e4553bd118fc1 Mon Sep 17 00:00:00 2001 > From: "Steven Rostedt (Red Hat)" <[email protected]> > Date: Mon, 24 Feb 2014 11:06:04 -0500 > Subject: [PATCH] tracepoint: Warn and notify if tracepoints are not loaded > due > to module taint > > If a module is loaded that is tainted with anything but OOT or CRAP, then > it will not create the tracepoint infrastructure for the module. The user > needs > to be warned when this happens instead of exiting silently. > > Fixes: 97e1c18e8d17 "tracing: Kernel Tracepoints" > Cc: [email protected] > Cc: Mathieu Desnoyers <[email protected]> > Signed-off-by: Steven Rostedt <[email protected]> > --- > kernel/tracepoint.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c > index 63630ae..1d33831 100644 > --- a/kernel/tracepoint.c > +++ b/kernel/tracepoint.c > @@ -649,8 +649,12 @@ static int tracepoint_module_coming(struct module *mod) > * module headers (for forced load), to make sure we don't cause a > crash. > * Staging and out-of-tree GPL modules are fine. > */ > - if (trace_module_has_bad_taint(mod)) > + if (trace_module_has_bad_taint(mod)) { > + pr_err("Module '%s' is tainted, ignoring its tracepoints\n", > + mod->name); > return 0; > + } > + > mutex_lock(&tracepoints_mutex); > tp_mod = kmalloc(sizeof(struct tp_module), GFP_KERNEL); > if (!tp_mod) { > -- > 1.8.1.4 > > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
