On 03/04/2014 11:12 AM, Alexander Shiyan wrote:
> Вторник,  4 марта 2014, 11:01 +02:00 от Peter Ujfalusi 
> <peter.ujfal...@ti.com>:
>> We can then remove the iounmap() calls from probe and remove.
>> Since the driver requests the resources via index we can do the mem resource
>> request within a for loop.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com>
>> Reviewed-by: Santosh Shilimkar <santosh.shilimkar@ti>
>> ---
> 
>> +    /* Get mem resources */
>> +    for (i = 0; i < 3; i++) {
>> +            struct resource *res = platform_get_resource(pdev,
>> +                                                         IORESOURCE_MEM, i);
>> +            if (!res) {
>> +                    dev_err(&pdev->dev, "couldn't find resource %d\n", i);
>> +                    return -ENODEV;
>> +            }
> 
> No need to check "res". devm_request_and_ioremap() do all for us.

True.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to