> segfaults here..
> 
> [jolsa@krava perf]$ ./perf record -g sleep 1
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.013 MB perf.data (~567 samples) ]
> [jolsa@krava perf]$ ./perf report
> perf: Segmentation fault
> [jolsa@krava perf]$ 

Thanks. Fixed with this patch:

commit 124014960a8fb09043914fb79ea86e0444408ab0
Author: Andi Kleen <[email protected]>
Date:   Wed Mar 5 07:28:56 2014 -0800

    perf, tools, report: Fix perf report without -b
    
    Fix report crash when -b is not used. Reported by Jiri Olsa.
    
    Signed-off-by: Andi Kleen <[email protected]>

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index ef198c3..04ec451 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1381,15 +1381,15 @@ static int machine__resolve_callchain_sample(struct 
machine *machine,
         * - No annotations (should annotate somehow)
         */
 
-       if (branch->nr > PERF_MAX_BRANCH_DEPTH) {
-               pr_warning("corrupted branch chain. skipping...\n");
-               return 0;
-       }
-
-       if (callchain_param.branch_callstack) {
+       if (branch && callchain_param.branch_callstack) {
                int nr = min(max_stack, (int)branch->nr);
                struct branch_entry be[nr];
 
+               if (branch->nr > PERF_MAX_BRANCH_DEPTH) {
+                       pr_warning("corrupted branch chain. skipping...\n");
+                       return 0;
+               }
+
                for (i = 0; i < nr; i++) {
                        if (callchain_param.order == ORDER_CALLEE) {
                                be[i] = branch->entries[i];


-- 
[email protected] -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to