On Tue, Mar 11, 2014 at 01:25:53PM +0000, Mark Brown wrote: > On Tue, Mar 11, 2014 at 08:54:32PM +0800, Nicolin Chen wrote: > > Adding Jyri who's been looking at this as well but not added anyone else > working on simple-card so you might've missed his mails. > > > It's pretty fair to do it for DAIFMT_INV since two dais might have differnt > > definitions in their drivers even though it'd be better to keep it same if > > we could. > > No, that's not at all OK - anything that requires this is broken. The > same DAI format should be usable by both ends of the link unless the > board itself is inverting one of the signals or something.
That makes sense to me. Okay, I'll overwrite them all... > > > Thus this patch fixes it by overwriting the DAIFMT_MASTER bit of > > cpu_dai->fmt > > with the one of codec_dai->fmt since we defined DAIFMT_MASTER basing on > > CODEC > > at the first place. > > This seems closer to what I'd expect for something like this but it does > mean that any format settings on the CPU DAI will be ignored (rather > than say warning or something). I'm not sure this is a bad thing > though, probably wants the binding documenting at least. ...along with the binding doc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/