Maneesh Soni writes:
> On Wed, Feb 09, 2005 at 08:49:36PM -0600, Tom Zanussi wrote:
> [..]
> > + */
> > +struct dentry *relayfs_create_file(const char *name, struct dentry
> > *parent,
> > + int mode, struct rchan *chan)
> > +{
> > + struct dentry *dentry;
> > + int error;
> > +
> > + if (!mode)
> > + mode = S_IRUSR;
> > + mode = (mode & S_IALLUGO) | S_IFREG;
> > +
> > + error = relayfs_create_entry(name, parent, mode, chan, &dentry);
>
> ^^^^
> I think you missed GregKH's suggesstion to have relayfs_create_entry()
> return pointer to struct dentry, and reduce one parameter.
Yes, you're right - somehow I missed that one.
> > +
> > + if (unlikely(relay_buf_full(buf))) {
> > + return 0;
> > + buf->chan->cb->buf_full(buf);
>
> ^^^^^^^^
> Typo? statement after return !
Yikes! Obviously I haven't tested the buffer full condition yet ;-)
Thanks for pointing these out.
Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
