On Wed, Mar 12, 2014 at 8:15 PM, Luis R. Rodriguez <[email protected]> wrote: > spin_lock_bh(&p->br->lock); > err = br_setport(p, tb); > + changed = br_stp_recalculate_bridge_id(p->br);
Looks like you only want to check if the mac addr gets changed here, but br_stp_recalculate_bridge_id() does more than just checking it, are you sure the side-effects are all what you want here? > spin_unlock_bh(&p->br->lock); > + if (changed) > + call_netdevice_notifiers(NETDEV_CHANGEADDR, > + p->br->dev); > + netdev_update_features(p->br->dev); I think this is supposed to be in netdev event handler of br->dev instead of here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
