On Wednesday, February 26, 2014 10:21 AM, Jingoo Han wrote: > > For a constant format without additional arguments, use seq_puts() > instead of seq_printf(). Also, it fixes the following checkpatch > warning. > > WARNING: Prefer seq_puts to seq_printf > > Signed-off-by: Jingoo Han <jg1....@samsung.com> > --- > drivers/regulator/dbx500-prcmu.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/regulator/dbx500-prcmu.c > b/drivers/regulator/dbx500-prcmu.c > index f111dfb..3dd1096 100644 > --- a/drivers/regulator/dbx500-prcmu.c > +++ b/drivers/regulator/dbx500-prcmu.c > @@ -97,10 +97,10 @@ static int ux500_regulator_power_state_cnt_print(struct > seq_file *s, void *p) > int err; > > /* print power state count */ > - err = seq_printf(s, "ux500-regulator power state count: %i\n", > - power_state_active_get()); > + err = seq_puts(s, "ux500-regulator power state count: %i\n", > + power_state_active_get());
It makes build error with 'make ARCH=arm allmodconfig', as Fengguang Wu reported. drivers/regulator/dbx500-prcmu.c: In function 'ux500_regulator_power_state_cnt_print': drivers/regulator/dbx500-prcmu.c:103:4: error: too many arguments to function 'seq_puts' So, I will send v2 patch. Sorry for annoying you. Thank you. Best regards, Jingoo Han > if (err < 0) > - dev_err(dev, "seq_printf overflow\n"); > + dev_err(dev, "seq_puts overflow\n"); > > return 0; > } > @@ -127,9 +127,9 @@ static int ux500_regulator_status_print(struct seq_file > *s, void *p) > int i; > > /* print dump header */ > - err = seq_printf(s, "ux500-regulator status:\n"); > + err = seq_puts(s, "ux500-regulator status:\n"); > if (err < 0) > - dev_err(dev, "seq_printf overflow\n"); > + dev_err(dev, "seq_puts overflow\n"); > > err = seq_printf(s, "%31s : %8s : %8s\n", "current", > "before", "after"); > -- > 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
