Commit-ID: c5cdfdf90901c51363441365997eecd58efd9374 Gitweb: http://git.kernel.org/tip/c5cdfdf90901c51363441365997eecd58efd9374 Author: Jan Beulich <[email protected]> AuthorDate: Thu, 27 Feb 2014 08:47:34 +0000 Committer: H. Peter Anvin <[email protected]> CommitDate: Wed, 19 Mar 2014 16:51:04 -0700
x86, hash: Swap arguments passed to crc32_u32() ... to match the function's parameters. While reportedly commutative, using the proper order allows for leveraging the instruction permitting the source operand to be in memory. [ hpa: This code originated in the dpdk toolkit. This was a bug in dpdk which has recently been fixed in part due to an earlier version of this patch. ] Signed-off-by: Jan Beulich <[email protected]> Link: http://lkml.kernel.org/r/[email protected] Acked-by: Daniel Borkmann <[email protected]> Cc: Francesco Fusco <[email protected]> Cc: Thomas Graf <[email protected]> Cc: David S. Miller <[email protected]> Signed-off-by: H. Peter Anvin <[email protected]> --- arch/x86/lib/hash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/hash.c b/arch/x86/lib/hash.c index 060cc44..ac628aa 100644 --- a/arch/x86/lib/hash.c +++ b/arch/x86/lib/hash.c @@ -53,7 +53,7 @@ static u32 intel_crc4_2_hash(const void *data, u32 len, u32 seed) u32 i, tmp = 0; for (i = 0; i < len / 4; i++) - seed = crc32_u32(*p32++, seed); + seed = crc32_u32(seed, *p32++); switch (3 - (len & 0x03)) { case 0: @@ -64,7 +64,7 @@ static u32 intel_crc4_2_hash(const void *data, u32 len, u32 seed) /* fallthrough */ case 2: tmp |= *((const u8 *) p32); - seed = crc32_u32(tmp, seed); + seed = crc32_u32(seed, tmp); default: break; } @@ -78,7 +78,7 @@ static u32 intel_crc4_2_hash2(const u32 *data, u32 len, u32 seed) u32 i; for (i = 0; i < len; i++) - seed = crc32_u32(*p32++, seed); + seed = crc32_u32(seed, *p32++); return seed; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
