On Thu, 20 Mar 2014 22:53:25 +0100 Fabian Frederick <[email protected]> wrote:
> f9acc8c7b35a10 ("readahead: sanify file_ra_state names")
> left ra_submit with a single function call.
>
> Add 'inline' to save some stack (suggested by Andrew Morton).
>
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -246,7 +246,7 @@ unsigned long max_sane_readahead(unsigned long nr)
> /*
> * Submit IO for the read-ahead request in file_ra_state.
> */
> -unsigned long ra_submit(struct file_ra_state *ra,
> +inline unsigned long ra_submit(struct file_ra_state *ra,
> struct address_space *mapping, struct file *filp)
> {
> int actual;
The ra_submit() callsite in filemap.c will not be able to inline this
function because its definition is unavailable at compilation time.
ra_submit() should be made static inline and moved into a header file
which all callers include. Probably in mm.h's /* readahead */ section.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
