This patch is still needed in linux-next. It was Acked by Tony Prisk in a private email.
Acked-by: Tony Prisk <[email protected]> regards, dan carpenter On Mon, Aug 26, 2013 at 07:02:33PM +0300, Dan Carpenter wrote: > This does a bunch of looping like this: > > for (div2 = 7; div2 >= 0; div2--) > > But unsigned values are always greater than or equal to zero so it just > loops and loops. Really "mul", "div1" and "div2" should all be declared > as int for cleanliness sake. > > Signed-off-by: Dan Carpenter <[email protected]> > --- > Static checker stuff. > > diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c > index 82306f5..8d5b57c 100644 > --- a/drivers/clk/clk-vt8500.c > +++ b/drivers/clk/clk-vt8500.c > @@ -363,7 +363,7 @@ static void vt8500_find_pll_bits(unsigned long rate, > unsigned long parent_rate, > static void wm8650_find_pll_bits(unsigned long rate, unsigned long > parent_rate, > u32 *multiplier, u32 *divisor1, u32 *divisor2) > { > - u32 mul, div1, div2; > + int mul, div1, div2; > u32 best_mul, best_div1, best_div2; > unsigned long tclk, rate_err, best_err; > > @@ -431,7 +431,7 @@ static u32 wm8750_get_filter(u32 parent_rate, u32 > divisor1) > static void wm8750_find_pll_bits(unsigned long rate, unsigned long > parent_rate, > u32 *filter, u32 *multiplier, u32 *divisor1, > u32 *divisor2) > { > - u32 mul, div1, div2; > + int mul, div1, div2; > u32 best_mul, best_div1, best_div2; > unsigned long tclk, rate_err, best_err; > > @@ -475,7 +475,7 @@ static void wm8750_find_pll_bits(unsigned long rate, > unsigned long parent_rate, > static void wm8850_find_pll_bits(unsigned long rate, unsigned long > parent_rate, > u32 *multiplier, u32 *divisor1, u32 *divisor2) > { > - u32 mul, div1, div2; > + int mul, div1, div2; > u32 best_mul, best_div1, best_div2; > unsigned long tclk, rate_err, best_err; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
