On Fri, Apr 04, 2014 at 11:26:28AM -0400, David Miller wrote: > From: Peter Zijlstra <pet...@infradead.org> > Date: Fri, 4 Apr 2014 17:19:42 +0200 > > > The proper way to fix the dev_deactivate_many() is to use wait_event(), > > polling for that state is just daft. Afaict there is no reason the qdisc > > code could not do a wakeup whenever that condition changes. > > I actually looked into this, and it's going to add expensive checks > to the fast paths of packet processing. > > If it was so easy we'd be doing it that way already.
Fair enough; and I suppose this waiting side is 'rare' compared to the packet processing side of things? In that case you could add a comment with the msleep() and just leave it at that I suppose. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
