On Tue, Apr 1, 2014 at 10:01 AM, Tanya Brokhman <[email protected]> wrote: > In case of an error (if there are not free PEB's for example), > __wl_get_peb will return a negative value. In order to prevent access > violation we need to test the returned value prior to using it later on. > > Signed-off-by: Tatyana Brokhman <[email protected]> > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 02317c1..457ead3 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -684,6 +684,9 @@ int ubi_wl_get_peb(struct ubi_device *ubi) > peb = __wl_get_peb(ubi); > spin_unlock(&ubi->wl_lock); > > + if (peb < 0) > + return peb; > + > err = ubi_self_check_all_ff(ubi, peb, ubi->vid_hdr_aloffset, > ubi->peb_size - ubi->vid_hdr_aloffset); > if (err) {
Acked-by: Richard Weinberger <[email protected]> -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
