On Fri, 2014-04-11 at 13:41 -0400, Rik van Riel wrote: > On 04/11/2014 01:34 PM, Joe Perches wrote: > > On Fri, 2014-04-11 at 13:00 -0400, [email protected] wrote: > >> This should reduce the overhead of the automatic NUMA placement > >> code, when a workload spans multiple NUMA nodes. [] > > Perhaps local would look nicer as bool > > and be better placed next to migrated. > > The problem is, at the end of the function, local is used as an > array index...
Oh, thanks. > p->numa_faults_locality[local] += pages; > > I'm not sure I really want to use a bool as an array index :) Nor I particularly but using bool as an array index is already done in at least kernel/workqueue.c and kernel/trace/blktrace.c Doesn't make it right of course. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
