On Thu, 27 Mar 2014 10:54:19 -0700 Mitchel Humpherys <[email protected]>
wrote:
> printk is meant to be used with an associated log level. There are some
> instances of printk scattered around the mm code where the log level is
> missing. Add a log level and adhere to suggestions by
> scripts/checkpatch.pl by moving to the pr_* macros.
>
hm, this is a functional change.
> --- a/mm/bounce.c
> +++ b/mm/bounce.c
> @@ -3,6 +3,8 @@
> * - Split from highmem.c
> */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Because of this.
> #include <linux/mm.h>
> #include <linux/export.h>
> #include <linux/swap.h>
> @@ -15,6 +17,7 @@
> #include <linux/hash.h>
> #include <linux/highmem.h>
> #include <linux/bootmem.h>
> +#include <linux/printk.h>
> #include <asm/tlbflush.h>
>
> #include <trace/events/block.h>
> @@ -34,7 +37,7 @@ static __init int init_emergency_pool(void)
>
> page_pool = mempool_create_page_pool(POOL_SIZE, 0);
> BUG_ON(!page_pool);
> - printk("bounce pool size: %d pages\n", POOL_SIZE);
> + pr_info("bounce pool size: %d pages\n", POOL_SIZE);
This used to print "bounce pool size: N pages" but will now print
"bounce: bounce pool size: N pages".
It isn't necessarily a *bad* change but perhaps a little more thought
could be put into it. In this example it would be better remove the
redundancy by using
pr_info("pool size: %d pages\n"...);
And all of this should be described and justified in the changelog,
please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
