Hello, On Sat, Apr 19, 2014 at 10:04:06PM +0800, Lai Jiangshan wrote: > On Sat, Apr 19, 2014 at 9:07 PM, Tejun Heo <t...@kernel.org> wrote: > WARN_ON_ONCE() for invalid id (negative id). > idr_remove_warning() for unallocated id.
I don't know. Seem like an unnecessary distinction. > >> @@ -1030,6 +1030,9 @@ void ida_remove(struct ida *ida, int id) > >> int n; > >> struct ida_bitmap *bitmap; > >> > >> + if (WARN_ON_ONCE(id < 0)) > >> + return; > > > > Why not jump to err? > > WARN_ON_ONCE() for invalid id (negative id). > "goto err" for unallocated id. Ditto. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
