On pon, 2014-04-21 at 21:02 +0900, Chanwoo Choi wrote:
> This patch use devm_extcon_dev_allocate() to simplify the memory control
> of extcon device.
> 
> Cc: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Chanwoo Choi <[email protected]>
> ---
>  drivers/extcon/extcon-max14577.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


> diff --git a/drivers/extcon/extcon-max14577.c 
> b/drivers/extcon/extcon-max14577.c
> index 7221b32..3d24dae 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -668,13 +668,14 @@ static int max14577_muic_probe(struct platform_device 
> *pdev)
>       }
>  
>       /* Initialize extcon device */
> -     info->edev = devm_kzalloc(&pdev->dev, sizeof(*info->edev), GFP_KERNEL);
> +     info->edev = devm_extcon_dev_allocate(&pdev->dev,
> +                                           max14577_extcon_cable);
>       if (!info->edev) {
>               dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
>               return -ENOMEM;
>       }
>       info->edev->name = DEV_NAME;
> -     info->edev->supported_cable = max14577_extcon_cable;
> +
>       ret = devm_extcon_dev_register(&pdev->dev, info->edev);
>       if (ret) {
>               dev_err(&pdev->dev, "failed to register extcon device\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to