On Wed, Apr 16, 2014 at 10:40 PM, Andrew Bresticker <[email protected]> wrote:
> The AS3722_GPIO_INV bit will always be blindly overwritten by > as3722_pinctrl_gpio_set_direction() and will be ignored when > setting the value of the GPIO in as3722_gpio_set() since the > enable_gpio_invert flag is never set. This will cause an > initially inverted GPIO to toggle when requested as an output, > which could be problematic if, for example, the GPIO controls > a critical regulator. > > Instead of setting up the enable_gpio_invert flag, just leave > the invert bit alone and check it before setting the GPIO value. > > Cc: <[email protected]> # v3.14+ > Signed-off-by: Andrew Bresticker <[email protected]> > Reviewed-by: Stephen Warren <[email protected]> > Tested-by: Stephen Warren <[email protected]> > --- > Changes from v1: > - fixed typo This v2 version applied for fixes with Laxman's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
