On Mon, Apr 21, 2014 at 11:24:20AM -0700, Dave Hansen wrote: > > From: Dave Hansen <[email protected]> > > The > > if (cpumask_any_but(mm_cpumask(mm), smp_processor_id()) < nr_cpu_ids) > > line of code is not exactly the easiest to audit, especially when > it ends up at two different indentation levels. This eliminates > one of the the copy-n-paste versions. It also gives us a unified > exit point for each path through this function. We need this in > a minute for our tracepoint. > > > Signed-off-by: Dave Hansen <[email protected]> > --- > > b/arch/x86/mm/tlb.c | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff -puN arch/x86/mm/tlb.c~simplify-tlb-code arch/x86/mm/tlb.c > --- a/arch/x86/mm/tlb.c~simplify-tlb-code 2014-04-21 11:10:34.431818610 > -0700 > +++ b/arch/x86/mm/tlb.c 2014-04-21 11:10:34.435818791 -0700 > @@ -161,23 +161,24 @@ void flush_tlb_current_task(void) > void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, > unsigned long end, unsigned long vmflag) > { > + int need_flush_others_all = 1; > unsigned long addr; > unsigned act_entries, tlb_entries = 0; > unsigned long nr_base_pages; >
Could make that bool but otherwise Acked-by: Mel Gorman <[email protected]> -- Mel Gorman SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
