On Fri, Apr 25, 2014 at 10:48:22AM -0300, Nicolas Del Piano wrote: > Fixed a coding style error, macros with complex values should be enclosed in > parentheses. > > Signed-off-by: Nicolas Del Piano <[email protected]> > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c > b/drivers/staging/octeon-usb/octeon-hcd.c > index 8b8ce72..ef3a8ce 100644 > --- a/drivers/staging/octeon-usb/octeon-hcd.c > +++ b/drivers/staging/octeon-usb/octeon-hcd.c > @@ -246,7 +246,7 @@ enum cvmx_usb_pipe_flags { > }; > > /* Normal prefetch that use the pref instruction. */ > -#define CVMX_PREFETCH(address, offset) asm volatile ("pref %[type], > %[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n" > (0)) > +#define CVMX_PREFETCH(address, offset) (asm volatile ("pref %[type], > %[off](%[rbase])" : : [rbase] "d" (address), [off] "I" (offset), [type] "n" > (0))) > > /* Maximum number of times to retry failed transactions */ > #define MAX_RETRIES 3
Will that actually compile? Why the heck are we using asm in a define in the first place? Shouldn't this be an inline function or something? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
