On Fri, Apr 25, 2014 at 09:42:19AM +0900, Chanwoo Choi wrote: > This patch use devm_extcon_dev_allocate() to simplify the memory control > of extcon device. > > Signed-off-by: Chanwoo Choi <[email protected]> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Felipe Balbi <[email protected]> > --- > drivers/extcon/extcon-max77693.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/extcon/extcon-max77693.c > b/drivers/extcon/extcon-max77693.c > index f0f18e2..2c7c3e1 100644 > --- a/drivers/extcon/extcon-max77693.c > +++ b/drivers/extcon/extcon-max77693.c > @@ -1175,23 +1175,22 @@ static int max77693_muic_probe(struct platform_device > *pdev) > } > > /* Initialize extcon device */ > - info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev), > - GFP_KERNEL); > - if (!info->edev) { > + info->edev = devm_extcon_dev_allocate(&pdev->dev, > + max77693_extcon_cable); you're using spaces for indentation here, I suppose that was intentional to align the following line to the opening (. No strong feelings but IIRC checkpatch.pl --strict will complain about it. > + if (IS_ERR(info->edev)) { > dev_err(&pdev->dev, "failed to allocate memory for extcon\n"); > ret = -ENOMEM; > goto err_irq; > } > info->edev->name = DEV_NAME; > info->edev->dev.parent = &pdev->dev; > - info->edev->supported_cable = max77693_extcon_cable; > + > ret = devm_extcon_dev_register(&pdev->dev, info->edev); > if (ret) { > dev_err(&pdev->dev, "failed to register extcon device\n"); > goto err_irq; > } > > - > /* Initialize MUIC register by using platform data or default data */ > if (pdata && pdata->muic_data) { > init_data = pdata->muic_data->init_data; > -- > 1.8.0 > -- balbi
signature.asc
Description: Digital signature
