On Tue, Apr 01, 2014 at 12:43:36AM +0900, Masanari Iida wrote: > Fix format string mismatch in mangle_connect_len()
All these patches seem like pointless noise to me. In none of these cases can the value legitimately be negative. If anything, you should fix the types to be unsigned. > > Signed-off-by: Masanari Iida <standby2...@gmail.com> > --- > net/netfilter/nf_nat_sip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/nf_nat_sip.c b/net/netfilter/nf_nat_sip.c > index b4d691d..5f98845 100644 > --- a/net/netfilter/nf_nat_sip.c > +++ b/net/netfilter/nf_nat_sip.c > @@ -434,7 +434,7 @@ static int mangle_content_len(struct sk_buff *skb, > unsigned int protoff, > &matchoff, &matchlen) <= 0) > return 0; > > - buflen = sprintf(buffer, "%u", c_len); > + buflen = sprintf(buffer, "%d", c_len); > return mangle_packet(skb, protoff, dataoff, dptr, datalen, > matchoff, matchlen, buffer, buflen); > } > -- > 1.9.1.352.gd393d14 > > -- > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
