> > So why not just: > > revision = (unsigned long)match->data; > > and add a comment that the 0x84 is the revision - #define ?? > > There is no particular reason why it should be u32 now - this is a > leftover from the previous iteration of code where revision was a > separate property in DT (sized u32). It actually mirrors the > respective field in struct pci_dev, which is u8 - don't see any issue > defining it as unsigned long (and also changing the definition in > struct rhine_private). > > The comment that it's the revision is right above the match table (cut > off in the patch) :) > > Jan, would you prefer to adjust your patch, or shall I send another > one to change rp->revision and friends to unsigned long?
I prefer you to make another patch, you obviously know more about this driver. Also thanks for suggesting (void*)->(unsigned long), I didn't know that these two are defined to have the same size (in kernel code). -- Jan Matějka <[email protected]> SUSE Labs
signature.asc
Description: Digital signature
