On 13 May 01:15 PM, Greg Kroah-Hartman wrote: > On Mon, May 12, 2014 at 11:26:14PM -0300, Ezequiel Garcia wrote: > > On 12 May 05:50 PM, Brian Norris wrote: > > > > There are some guidelines about attributes in > > > > 'Documentation/filesystems/sysfs.txt' > > > > Though it's acceptable to put array of values of the "same type" in > > > > single sysfs file, > > > > But I'm still not confident on having all members of 'struct ecc_stats' > > > > being > > > > represented by single sysfs file > > > [...] > > > > > > I agree, it looks like the sysfs policy would recommend against putting > > > distinct properties in the same file. > > > > > > > OK... > > > > > I'm not sure if /sys/block/<disk>/stat is a good example, as it does > > > violate this policy. It also seems to have some historical baggage. > > > > > > But there is potentially one good reason for putting this distinct > > > information in a single file: if the information must be returned > > > atomically. For disk stats, it might be important to get a consistent > > > snapshot of the disk stats (or nearly so, with minimal locking > > > overhead), which might change significantly between file accesses if > > > we're doing half a dozen file queries instead. > > > > > > This same reason may not apply to these ECC stats, since none of these > > > ECC stats are likely to be changing concurrently. > > > > > > > Right. > > > > > So I personally might lean toward "one file per attribute" here. > > > > > > > Yup, no problem. Greg, if you can confirm this it'd be great. > > Yes, that is the rule for sysfs, please do not put multiple values in a > single sysfs file for a variety of good reasons. >
Will do! > > > > >> I hope this will still keep it machine readable. > > > > >Well, this is not a debugfs entry, so I'm not sure we want to add such > > > > >debug > > > > >information. Anyone can take a look at the code and see what ecc_stats > > > > >mean. > > > > > > The code or (as suggested by Pekon) the documentation > > > (Documentation/ABI/). Either way -- with a single 'ecc_stats' table, or > > > with 4 separate files -- they need to be documented. > > > > > > > Sure, will document in next round. > > This documentation is required, thanks. > Sure, no problem. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
