On Wed, May 14, 2014 at 11:06:29AM +0200, Peter Zijlstra wrote:
> > +   llist_add(&work->llnode, &per_cpu(irq_work_list, cpu));
> > +   native_send_call_func_single_ipi(cpu);
> 
> At the very leastestest make that:
> 
>       if (llist_add(&work->llnode, &per_cpu(irq_work_list, cpu)))
>               native_send_call_func_single_ipi(cpu);
> 
> But ideally, also test the IRQ_WORK_LAZY support, its weird to have that
> only be supported for the other queue.
> 
> Hmm, why do we need that LAZY crap, that completely wrecks a perfectly
> simple thing.
> 
> The changelog (bc6679aef673f), not the printk() usage make much sense,

s/not/nor/

> printk() can't cause an IPI storm... printk() isn't fast enough to storm
> anything.

Except, as we all know, slow serial lines.

Attachment: pgpzMmDC7VbbP.pgp
Description: PGP signature

Reply via email to