Linus, On Fri, May 16, 2014 at 03:35:48PM +0200, Linus Walleij wrote: > On Mon, May 5, 2014 at 7:27 AM, Antoine Ténart > <[email protected]> wrote: > > > Add the documentation related to the Berlin pin-controller driver and > > explain how to configure this group based controller. > > > > Signed-off-by: Antoine Ténart <[email protected]> > > Acked-by: Sebastian Hesselbarth <[email protected]> > (...) > > When I see this: > > > +Required subnode-properties: > > +- marvell,groups: a list of strings describing the group names. > > +- marvell,function: a string describing the function used to mux the > > groups. > > + > > +Example: > > + > > +sm_pinctrl: pin-controller@0 { > > + compatible = "marvell,berlin2q-sysmgr-pinctrl"; > > + reg = <0xfc0000 0x44>; > > + > > + uart0_pmux: uart0-pmux { > > + marvell,groups = "GSM12", "GSM13"; > > + marvell,function = "uart0"; > > + }; > > +} > > I feel like ... can't we just standardize that and make it a common > pinctrl binding, and name the properties "groups" and "function" > for a family of pin controllers just mapping N groups to 1 function? > > I will merge the patches as are, but maybe we can make it generic > on top of this before the merge window?
Do you mean just changing: s/marvell,groups/groups/ s/marvell,function/function/ and updating the documentation ? If so, I can definitely do that. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
