Hi, On Wednesday 05 March 2014 01:25 PM, Mark Rutland wrote: > On Fri, Feb 14, 2014 at 11:23:56AM +0000, Lee Jones wrote: >> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe >> devices. It has 2 ports which it can use for either; both SATA, both >> PCIe or one of each in any configuration. >> >> Cc: Kishon Vijay Abraham I <[email protected]> >> Signed-off-by: Lee Jones <[email protected]> >> --- >> drivers/phy/Kconfig | 10 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-miphy365x.c | 614 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 625 insertions(+) >> create mode 100644 drivers/phy/phy-miphy365x.c > > [...] > >> +enum miphy_sata_gen { >> + SATA_GEN1 = 1, >> + SATA_GEN2, >> + SATA_GEN3 >> +}; > > It would be nice to have a comment here that these values are ABI and > cannot change. > > [...] > >> +static struct phy *miphy365x_phy_xlate(struct device *dev, >> + struct of_phandle_args *args) >> +{ >> + struct miphy365x_dev *state = dev_get_drvdata(dev); >> + u8 port = args->args[0]; >> + u8 type = args->args[1]; > > In case of a bad dt, it would be nice to check args->arg_count == 2. > > ALso, we throw away the top 24 bits, which may have been set > erroneously. If we want to make use of those in future we should test > they are clear here to force people to do the right thing.
I don't seem to have the update patch series? Can you resend please? Thanks Kishon > > Otherwise, this looks fine to me. > > With those additions: > > Acked-by: Mark Rutland <[email protected]> > > Cheers, > Mark. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
