On Mon, May 19, 2014 at 04:44:57PM +0200, Jonas Bonn wrote: > This looks good. Let's complete the the cleanup of this driver while > we're at it: > > i) Move this file to drivers/irqchip/
Sure, that sounds like a good idea. > ii) Put a Depends on CONFIG_ARCH_OPENRISC in the Kconfig Hmm, do we really need that? The irqchip driver will picked by 'select'ing it from arch/openrisc/Kconfig So, it won't really be exposed to anyone not explicitly picking it like that. > iii) Provide documentation for the binding at > Documentation/devicetree/bindings/interrupt-controller/ > > Copy final result to Thomas Gleixner who maintains the irqchip bits. > Will do. > > @@ -19,10 +19,13 @@ > > #include <linux/of.h> > > #include <linux/ftrace.h> > > Do we really need to pull in ftrace.h? > The '__irq_entry' that is used below is defined in that > > > > void __irq_entry do_IRQ(struct pt_regs *regs) > > Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/