Hi Mike,
On 05/15/2014 03:28 PM, Fabio Estevam wrote:
Hi Mike,
On Wed, May 7, 2014 at 1:48 PM, Maxime COQUELIN <[email protected]> wrote:
Commit 1d9fe6b97 ("clk: divider: Fix best div calculation for power-of-two and
table dividers") introduces a regression in its _table_round_up function.
When the divider passed to this function is greater than the max divider
available in the table, this function returns table's max divider.
Problem is that it causes an infinite loop in clk_divider_bestdiv() because
_next_div() will never return a value greater than maxdiv.
Instead of returning table's max divider, this patch returns INT_MAX.
Reported-by: Fabio Estevam <[email protected]>
Reported-by: Shawn Guo <[email protected]>
Tested-by: Fabio Estevam <[email protected]>
Cc: Mike Turquette <[email protected]>
Signed-off-by: Maxime Coquelin <[email protected]>
Any comments on this one? It does fix a regression.
This patch is important as it fixes a regression, could you review it
please?
Thanks,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
