> On Thursday 22 May 2014 12:24:07 Lee Jones wrote: > > + /* Mask to apply on boot_device_reg */ > > + ret = of_property_read_u32(np, "st,boot-device-msk", > > &boot_device_msk); > > + if (ret) > > + goto boot_device_fail; > > + > > > > The binding defines this property as "optional", but the driver fails > here if it's not provided. I suggest you add a default value here so you > can deal with existing dts. The default should be documented in > the binding as well.
The property is optional. It doesn't fail completely, merely skips the boot device check and falls back to using SPI. I can update the documentation to this effect though, no problem. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
