On 05/29/2014 12:28 AM, Pranith Kumar wrote:

> diff --git a/kernel/sched/cpupri.c b/kernel/sched/cpupri.c
> index 3031bac..a5635ad 100644
> --- a/kernel/sched/cpupri.c
> +++ b/kernel/sched/cpupri.c
> @@ -164,7 +164,7 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
>                * do a write memory barrier, and then update the count, to
>                * make sure the vector is visible when count is set.
>                */
> -             smp_mb__before_atomic_inc();
> +             smp_mb__before_atomic();
>               atomic_inc(&(vec)->count);
>               do_mb = 1;
>       }
> @@ -184,14 +184,14 @@ void cpupri_set(struct cpupri *cp, int cpu, int newpri)
>                * the new priority vec.
>                */
>               if (do_mb)
> -                     smp_mb__after_atomic_inc();
> +                     smp_mb__after_atomic();
>  
>               /*
>                * When removing from the vector, we decrement the counter first
>                * do a memory barrier and then clear the mask.
>                */
>               atomic_dec(&(vec)->count);
> -             smp_mb__after_atomic_inc();
> +             smp_mb__after_atomic();
>               cpumask_clear_cpu(cpu, vec->mask);
>       }
>  

We should at the least fix this :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to