Hi Charles, On 05/30/2014 06:36 PM, Charles Keepax wrote: > On Fri, May 30, 2014 at 10:41:39AM +0900, Chanwoo Choi wrote: >> This patch set the parent device of extcon device using first parameter of >> devm_extco_dev_allocate() to remove duplicate code on all of extcon provider >> drivers. >> >> Signed-off-by: Chanwoo Choi <[email protected]> >> Reported-by: Charles Keepax <[email protected]> >> Cc: Charles Keepax <[email protected]> >> Cc: Mark Brown <[email protected]> >> Cc: Graeme Gregory <[email protected]> >> Cc: Kishon Vijay Abraham I <[email protected]> >> Cc: Krzysztof Kozlowski <[email protected]> >> --- >> drivers/extcon/extcon-adc-jack.c | 1 - >> drivers/extcon/extcon-arizona.c | 1 - >> drivers/extcon/extcon-class.c | 2 ++ >> drivers/extcon/extcon-gpio.c | 1 - >> drivers/extcon/extcon-max77693.c | 1 - >> drivers/extcon/extcon-max8997.c | 1 - >> drivers/extcon/extcon-palmas.c | 1 - >> 7 files changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/extcon/extcon-adc-jack.c >> b/drivers/extcon/extcon-adc-jack.c >> index e18f95b..d860229 100644 >> --- a/drivers/extcon/extcon-adc-jack.c >> +++ b/drivers/extcon/extcon-adc-jack.c >> @@ -112,7 +112,6 @@ static int adc_jack_probe(struct platform_device *pdev) >> dev_err(&pdev->dev, "failed to allocate extcon device\n"); >> return -ENOMEM; >> } >> - data->edev->dev.parent = &pdev->dev; >> data->edev->name = pdata->name; >> >> /* Check the length of array and set num_cables */ >> diff --git a/drivers/extcon/extcon-arizona.c >> b/drivers/extcon/extcon-arizona.c >> index c634796..d9bd3c3 100644 >> --- a/drivers/extcon/extcon-arizona.c >> +++ b/drivers/extcon/extcon-arizona.c >> @@ -1165,7 +1165,6 @@ static int arizona_extcon_probe(struct platform_device >> *pdev) >> return -ENOMEM; >> } >> info->edev->name = "Headset Jack"; >> - info->edev->dev.parent = arizona->dev; >> >> ret = devm_extcon_dev_register(&pdev->dev, info->edev); > > This changes the parent device for the Arizona stuff, I don't > think this is a problem but I should probably test here first.
OK, Let me know about test result. Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
