2014-06-04 (수), 14:07 +0200, Joseph Schuchart: > Provide additional sample information on generic events > to Python scripts, including pid, tid, and cpu for which the event was > recorded. At the moment, the pointer to the sample struct is passed to > scripts, which seems to be of little use. The patch puts this information in > a dictionary for easy access by Python scripts. > > Signed-off-by: Joseph Schuchart <[email protected]> > Acked-by: Thomas Ilsche <[email protected]>
I think it'd be better adding sample->ip also, but anyway Acked-by: Namhyung Kim <[email protected]> Thank you for doing this work! Namhyung > --- > .../util/scripting-engines/trace-event-python.c | 21 > ++++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/util/scripting-engines/trace-event-python.c > b/tools/perf/util/scripting-engines/trace-event-python.c > index 4f81dc7..c8d148b 100644 > --- a/tools/perf/util/scripting-engines/trace-event-python.c > +++ b/tools/perf/util/scripting-engines/trace-event-python.c > @@ -445,7 +445,7 @@ static void python_process_general_event(struct > perf_sample *sample, > struct thread *thread, > struct addr_location *al) > { > - PyObject *handler, *retval, *t, *dict, *callchain; > + PyObject *handler, *retval, *t, *dict, *callchain, *dict_sample; > static char handler_name[64]; > unsigned n = 0; > > @@ -461,6 +461,10 @@ static void python_process_general_event(struct > perf_sample *sample, > if (!dict) > Py_FatalError("couldn't create Python dictionary"); > > + dict_sample = PyDict_New(); > + if (!dict_sample) > + Py_FatalError("couldn't create Python dictionary"); > + > snprintf(handler_name, sizeof(handler_name), "%s", "process_event"); > > handler = PyDict_GetItemString(main_dict, handler_name); > @@ -470,8 +474,19 @@ static void python_process_general_event(struct > perf_sample *sample, > pydict_set_item_string_decref(dict, "ev_name", > PyString_FromString(perf_evsel__name(evsel))); > pydict_set_item_string_decref(dict, "attr", PyString_FromStringAndSize( > (const char *)&evsel->attr, sizeof(evsel->attr))); > - pydict_set_item_string_decref(dict, "sample", > PyString_FromStringAndSize( > - (const char *)sample, sizeof(*sample))); > + > + pydict_set_item_string_decref(dict_sample, "pid", > + PyInt_FromLong(sample->pid)); > + pydict_set_item_string_decref(dict_sample, "tid", > + PyInt_FromLong(sample->tid)); > + pydict_set_item_string_decref(dict_sample, "cpu", > + PyInt_FromLong(sample->cpu)); > + pydict_set_item_string_decref(dict_sample, "time", > + PyLong_FromUnsignedLongLong(sample->time)); > + pydict_set_item_string_decref(dict_sample, "period", > + PyLong_FromUnsignedLongLong(sample->period)); > + pydict_set_item_string_decref(dict, "sample", dict_sample); > + > pydict_set_item_string_decref(dict, "raw_buf", > PyString_FromStringAndSize( > (const char *)sample->raw_data, sample->raw_size)); > pydict_set_item_string_decref(dict, "comm", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
