On Mon, 9 Jun 2014, Stanislav Fomichev wrote:
> In hrtimer_get_next_event we unconditionally lock/unlock spinlock, even if
> it's
> not required (hrtimer_hres_active() != 0). This patch moves
> locking/unlocking and mindelta range check inside the if clause,
> so we don't execute unnecessary operations.
What's wrong with simply doing:
if (!hrtimer_hres_active())
return mindelta;
That saves and indentation level and makes the code more
readable. Also the lockless check wants a comment why it is correct.
Thanks,
tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
