Hi Mark, On 06/10/2014 04:55 AM, Mark Brown wrote: > On Mon, Jun 09, 2014 at 03:15:47PM +0900, Chanwoo Choi wrote: >> This patch add S2MPU02 regulator device to existing S2MPS11 device driver >> because of little difference between S2MPS1x and S2MPU02. The S2MPU02 >> regulator device includes LDO[1-28] and BUCK[1-7]. > > Acked-by: Mark Brown <[email protected]> > > but a few nits: > >> + case S2MPS14X: >> + switch (rdev_id) { >> + case S2MPS14_LDO3: >> + return 0; >> + }; > > Extra ; here, and a missing default case here and in the rest of the > switches. The default cases have no effect but are better style. >
OK, I'll add 'default' case statement. Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
