On Thu, Jun 5, 2014 at 12:45 AM, David Miller <da...@davemloft.net> wrote:
> From: Iyappan Subramanian <isubraman...@apm.com>
> Date: Mon, 2 Jun 2014 12:39:14 -0700
>
>> + netdev_err(ndev, "LERR: %d ring_num: %d ", status, ring->num);
>> + switch (status) {
>> + case HBF_READ_DATA:
>> + netdev_err(ndev, "HBF read data error\n");
>> + break;
>
> This is not really appropriate.
>
> We have statistics like the ones you are incrementing in this
> function as the mechanism people can use to learn what events
> happened on an interface, and how many times they happened.
>
> Therefore, emitting a log message for each one of those events too is
> not necessary.
>
> We don't emit a netdev_err() for every packet that the IPv4 stack
> drops due to a bad checksum, for example.
>
> Please get rid of this.
Sure. I will remove the error message prints and clean up the function.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
