On Wed, Jun 11, 2014 at 09:02:15PM +0200, Borislav Petkov wrote: > > +EXPORT_SYMBOL_GPL(cper_mem_err_pack); > > Why do we export this one and the one below? What .config warrants this? > > CONFIG_ACPI_EXTLOG=m doesn't need them, AFAICT. > Right. acpi_extlog doesn't use it. They can be exported later until needed.
> > + TP_STRUCT__entry( > > + __field(u32, err_seq) > > + __field(u8, etype) > > + __field(u8, sev) > > + __field(u64, pa) > > + __field(u8, pa_mask_lsb) > > + __array(u8, fru_id, 40) > > How did you come up with this magic number? Why isn't that sizeof(uuid_le)? Cause I want to convert it into a string. > > + snprintf(__entry->fru_id, 39, "%pUl", fru_id); > > Yeah, I didn't catch the reasoning behind why we need to convert the FRU > into a string and not leave it simply as u8[16]... Fair enough. It can be compressed a little bit more.
signature.asc
Description: Digital signature
