Joonsoo Kim <iamjoonsoo....@lge.com> writes:

> We don't need explicit 'CMA:' prefix, since we already define prefix
> 'cma:' in pr_fmt. So remove it.
>
> And, some logs print function name and others doesn't. This looks
> bad to me, so I unify log format to print function name consistently.
>
> Lastly, I add one more debug log on cma_activate_area().
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo....@lge.com>
>
> diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
> index 83969f8..bd0bb81 100644
> --- a/drivers/base/dma-contiguous.c
> +++ b/drivers/base/dma-contiguous.c
> @@ -144,7 +144,7 @@ void __init dma_contiguous_reserve(phys_addr_t limit)
>       }
>
>       if (selected_size && !dma_contiguous_default_area) {
> -             pr_debug("%s: reserving %ld MiB for global area\n", __func__,
> +             pr_debug("%s(): reserving %ld MiB for global area\n", __func__,
>                        (unsigned long)selected_size / SZ_1M);

Do we need to do function(), or just function:. I have seen the later
usage in other parts of the kernel.

>
>               dma_contiguous_reserve_area(selected_size, selected_base,
> @@ -163,8 +163,9 @@ static int __init cma_activate_area(struct cma *cma)
>       unsigned i = cma->count >> pageblock_order;
>       struct zone *zone;
>
> -     cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
> +     pr_debug("%s()\n", __func__);

why ?

>
> +     cma->bitmap = kzalloc(bitmap_size, GFP_KERNEL);
>       if (!cma->bitmap)
>               return -ENOMEM;
>
> @@ -234,7 +235,8 @@ int __init dma_contiguous_reserve_area(phys_addr_t size, 
> phys_addr_t base,
>
>       /* Sanity checks */
>       if (cma_area_count == ARRAY_SIZE(cma_areas)) {
> -             pr_err("Not enough slots for CMA reserved regions!\n");
> +             pr_err("%s(): Not enough slots for CMA reserved regions!\n",
> +                     __func__);
>               return -ENOSPC;
>       }
>
> @@ -274,14 +276,15 @@ int __init dma_contiguous_reserve_area(phys_addr_t 
> size, phys_addr_t base,
>       *res_cma = cma;
>       cma_area_count++;
>
> -     pr_info("CMA: reserved %ld MiB at %08lx\n", (unsigned long)size / SZ_1M,
> -             (unsigned long)base);
> +     pr_info("%s(): reserved %ld MiB at %08lx\n",
> +             __func__, (unsigned long)size / SZ_1M, (unsigned long)base);
>
>       /* Architecture specific contiguous memory fixup. */
>       dma_contiguous_early_fixup(base, size);
>       return 0;
>  err:
> -     pr_err("CMA: failed to reserve %ld MiB\n", (unsigned long)size / SZ_1M);
> +     pr_err("%s(): failed to reserve %ld MiB\n",
> +             __func__, (unsigned long)size / SZ_1M);
>       return ret;
>  }
>
> -- 
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to