Joonsoo Kim <iamjoonsoo....@lge.com> writes:

> We can remove one call sites for clear_cma_bitmap() if we first
> call it before checking error number.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo....@lge.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>

>
> diff --git a/mm/cma.c b/mm/cma.c
> index 1e1b017..01a0713 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -282,11 +282,12 @@ struct page *cma_alloc(struct cma *cma, int count, 
> unsigned int align)
>               if (ret == 0) {
>                       page = pfn_to_page(pfn);
>                       break;
> -             } else if (ret != -EBUSY) {
> -                     clear_cma_bitmap(cma, pfn, count);
> -                     break;
>               }
> +
>               clear_cma_bitmap(cma, pfn, count);
> +             if (ret != -EBUSY)
> +                     break;
> +
>               pr_debug("%s(): memory range at %p is busy, retrying\n",
>                        __func__, pfn_to_page(pfn));
>               /* try again with a bit different memory target */
> -- 
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to