> -----Original Message----- > From: [email protected] > [mailto:[email protected]] On > Behalf Of David Rientjes > Sent: Monday, June 16, 2014 7:37 PM > To: Nick Krause > Cc: Steve Wise; [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; > [email protected] > Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc > > On Mon, 16 Jun 2014, Nick Krause wrote: > > > That's true David, > > I will resend this parch without the use of the pr_warn. > > There's no patch to resend if you don't use pr_warn(). kfree_skb(skb) is > unnecessary if !skb, look at the first thing it checks: > > void kfree_skb(struct sk_buff *skb) > { > if (unlikely(!skb)) > return; > ... > } > > Thus, I don't see the memory leak you're referring to.
send_flowc() still needs to handle a NULL return from get_skb(). That is what the bug report is addressing... Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
